[bug] Fix Self-suppression when close rethrows the same exception in FileIO.overwriteFileUtf8 (#9674) - #9679
Merged
JingsongLi merged 1 commit intoSep 11, 2026
Conversation
…hrows the same exception (apache#9674)
JingsongLi
reviewed
Sep 11, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
This has practical value in the reported dedicated-compaction failure: HintFileUtils.commitHint retries IOException, but try-with-resources self-suppression replaces it with IllegalArgumentException and bypasses that retry path. The identity check preserves the original I/O failure while retaining a distinct close exception as suppressed.
I verified four focused scenarios against the changed FileIO: identical write/close exception, distinct exceptions, close-only failure, and success. They pass on JDK 8. Please add these as repository regression tests; the PR currently changes only production code. I did not reproduce the full HDFS compaction job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9674